Skip to content

Faster to import std.regex, by lazy eval of wordMatcher #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

DmitryOlshansky
Copy link
Member

After:
▶ time dmd test_case.d
dmd test_case.d 0.24s user 0.03s system 98% cpu 0.269 total

▶ gco master
Switched to branch 'master'

Before:
▶ time dmd test_case.d
dmd test_case.d 1.10s user 0.12s system 99% cpu 1.228 total

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @DmitryOlshansky!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@quickfur
Copy link
Member

Woohoo!

@DmitryOlshansky
Copy link
Member Author

Credits go to @andralex actually

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@dlang-bot dlang-bot merged commit a00bd10 into dlang:master Dec 18, 2017
@CyberShadow
Copy link
Member

Before:

After:

Awesome!

@quickfur
Copy link
Member

Looks like std.uni is the next candidate for improvement. :-P

@andralex
Copy link
Member

@CyberShadow would be so nice to have that kind of information nicely visible on the website! "The upfront time cost of importing std modules"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants