-
-
Notifications
You must be signed in to change notification settings - Fork 740
Fix issue 18124 -- RegexMatch.front isn't clear as to what it returns #5976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inout as well). Fixes issue 18124
Thanks for your pull request, @schveiguy! Bugzilla references
|
I'm not sure this is a good idea. It binds us to an explicit return type that we may not be able to change in the future, e.g., if for example a future implementation wants to return distinct types for |
That ship has sailed, the return type is not a voldemort type, so code may already exists that uses the real type name. It's what I would do if I were stuffing the result into a struct. |
In fact, the docs of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, let's just go with this then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schveiguy Please see #5963
I think it's better to just update the docs
Wait, I apologize. I didn't see your other comments before I submitted the review. |
Easiest thing to do was explicitly type the result. It's probably less effort than documenting what it returns in ddoc, and is clearer to the user.
In all other cases in this file, the auto returns have explicit docs as to the return type. This really was the only anomaly.