-
Notifications
You must be signed in to change notification settings - Fork 414
Open
Description
Background
During the review of #3470, @rmuir pointed out that the dlt repository's GitHub Actions workflows are currently running with excessive privileges. This was the default org-level setting that grants full write access to GitHub tokens in use in workflows. This creates potential security risks.
Solution
Implement two tools for GitHub Actions analysis:
- https://github.com/zizmorcore/zizmor
- https://github.com/rhysd/actionlint
Tasks
- Research current workflow permissions: audit all existing
.github/workflows/*files. - Add explicit permissions to all workflows. e.g.
permissions: {} at workflow level to deny by default. Add minimal required permissions at job level where needed - Create CI workflow for workflow validation. See example implementation (from Apache Lucene): https://github.com/apache/lucene/blob/main/.github/workflows/actions.yml
- Configure triggers
- on PRs that modify .github/** paths
- on pushes to master/devel branches affecting .github/**
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Todo