Skip to content

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Mar 1, 2024

Fixes #999

I don't have this error on Python 3.10 and Python 3.11. Both versions had some changes in typing and its generics, so it seems to be an error of older Python versions.

@netlify
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit e890fcb
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/65e58a80f9690f00085c8a30

Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @IlyaFaer could you please also extend the test?

@IlyaFaer IlyaFaer marked this pull request as ready for review March 4, 2024 09:37
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @IlyaFaer

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@rudolfix rudolfix merged commit 483d4ae into devel Mar 4, 2024
@rudolfix rudolfix deleted the validate_no_name branch March 4, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.8-9: AttributeError in validate_dict() with TTableHintTemplate

4 participants