Enable merge write disposition for athena Iceberg
#1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jorritsandbrink
changed the title
delete-insert merge strategy for athena Icebergmerge write disposition for athena Iceberg
rudolfix
reviewed
May 6, 2024
| condition_columns, | ||
| ) | ||
| # DROP needs backtick as escape identifier | ||
| sql.insert(0, f"""DROP TABLE IF EXISTS {temp_table_name.replace('"', '`')};""") |
Collaborator
There was a problem hiding this comment.
yes, and there's PR (#998 ) that allows to escape for DDL and DML separately
rudolfix
deleted the
633-enable-delete-insert-merge-strategy-athena-iceberg
branch
toddy86
reviewed
May 7, 2024
| The `merge` write disposition is supported for Athena when using iceberg tables. | ||
|
|
||
| > Note that: | ||
| > 1. there is a risk of tables ending up in inconsistent state in case a pipeline run fails mid flight, because Athena doesn't support transactions, and `dlt` uses multiple DELETE/UPDATE/INSERT statements to implement `merge`, |
There was a problem hiding this comment.
Why not use the merge syntax that is available in Athena?
Collaborator
Author
There was a problem hiding this comment.
Full discussion is here: #1294.
TLDR: we're planning to add a new merge strategy based on the MERGE statement, but this isn't properly specced yet. We want consistent behavior accross different destinations, hence the implementation of delete-insert for athena now. MERGE-based merge for athena will come together with the other destinations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the
mergewrite disposition (bothdelete-insertandscd2strategies) for theathenadestination withicebergtable format.for
delete-insert:Related Issues
Additional Context
Discussion on how we end up using this approach on this PR: #1294