add typing classifier and update maintainers in pyproject #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update maintainers
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
approved these changes
May 21, 2024
Collaborator
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
LGTM!
are authors e-mails? we should probably say that authors are dlt contributors as per apache license. but that's a minor issue
Collaborator
Author
|
@rudolfix I'm not sure what your proposed change is exactly. Put the maintainers as authors and add a comment in the license or what do you have in mind? |
Collaborator
|
@sh-rp nvm. I should stop adding non-actionable thoughts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing typing classifier and updates maintainers in pyproject