RESTClient: implement AuthConfigBase.__bool__ + update docs #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext; change docs to suggest direct inheritance from AuthBase
✅ Deploy Preview for dlt-hub-docs canceled.
|
burnash
reviewed
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is resubmitted because I merged the last one with typing problems that made linting to fail. Let's try to fix our qdrant problem so we see CI green again...
linting fixes included
RESTClienttoAuthBasewhich is a common base forAuthConfigBaseand the one used by requests (AuthBaseitself)all tests including those in rest api source are passing after this
This PR implements bool on AuthConfigBase so instances of this class evaluate to True in requests.sessions.Session.prepare_request() when auth argument is evaluated otherwise instances of AuthConfigBase have no effect when passed as arguments to RESTClient's methods.
The PR also updates the documentation to suggest explicit inheritance from requests.auth.AuthBase for custom authentication.