Document sql source reflection level and type adapter #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| import dlt | ||
| from snowflake.sqlalchemy import TIMESTAMP_NTZ | ||
| import sqlalchemy as sa | ||
| from sqlalchemy.sql.sqltypes import TypeAdapter |
Contributor
There was a problem hiding this comment.
tests fail with
Module "sqlalchemy.sql.sqltypes" has no attribute "TypeAdapter"
may be you meant from pydantic import TypeAdapter ? or what version of sqlalchemy you have?
AstrakhantsevaAA
requested changes
Jun 24, 2024
Contributor
AstrakhantsevaAA
left a comment
AstrakhantsevaAA
left a comment
There was a problem hiding this comment.
Hi @steinitzu, could you fix the snippet, sqlalchemy.sql.sqltype doesn't have TypeAdapter
rudolfix
force-pushed
the
docs/sql-database-reflection-level
branch
from
758dd48 to
11d0cbb
Compare
rudolfix
force-pushed
the
docs/sql-database-reflection-level
branch
from
11d0cbb to
56f454e
Compare
rudolfix
approved these changes
Jul 8, 2024
rudolfix
added a commit
that referenced
this pull request
Jul 8, 2024
Document sql source reflection level and type adapter (#1467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docs for dlt-hub/verified-sources#487
Related Issues
Additional Context