Skip to content

Conversation

@rudolfix
Copy link
Collaborator

@rudolfix rudolfix commented Jul 2, 2024

Description

  1. credentials argument removed from Pipeline and helpers
  2. docs and tests are updated

@rudolfix rudolfix self-assigned this Jul 2, 2024
@netlify
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit d0a9c92
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66868460818eab0008c98a4b

@rudolfix rudolfix requested a review from sh-rp July 3, 2024 08:44
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Jul 3, 2024
)
config = p.destination_client().config
assert config.credentials.is_resolved()
print(dict(config.credentials))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print statement

sh-rp
sh-rp previously approved these changes Jul 3, 2024
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rudolfix rudolfix merged commit 6aedfdd into devel Jul 4, 2024
@rudolfix rudolfix deleted the rfix/removes-deprecated-credentials-arg branch July 4, 2024 13:52
@rudolfix rudolfix removed the sprint Marks group of tasks with core team focus at this moment label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants