adds missing docs / tests and configurable staging dataset name #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
added
the
sprint
sh-rp
reviewed
Jul 8, 2024
| if "%s" in self.staging_dataset_name_layout: | ||
| # if dataset name is empty, staging dataset name is also empty | ||
| dataset_name = self._make_dataset_name(schema.name) | ||
| if not dataset_name: |
Collaborator
There was a problem hiding this comment.
does this ever happen? I'm reading the code and trying to understand the mechanism, but in which case would the result of _make_dataset_name be None? Should't self.dataset_name always be set?
Collaborator
Author
There was a problem hiding this comment.
yes - in vector databases you can work on collections without dataset prefix. they override configuration making that field optional. btw. we should support that as well in clickhouse or dremio where we do not have schemas as well
sh-rp
previously approved these changes
Jul 8, 2024
rudolfix
force-pushed
the
feat/1486-docs-tests-update-0.5-staging
branch
from
d2c8f28 to
76728ba
Compare
rudolfix
removed
the
sprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds naming convention docs, missing tests and is implementing #919 (to get normalized staging dataset name without hacks)