feat/1495 rest_client: renames JSONResponsePaginator to JSONLinkPaginator

[willi-mueller]

Description

Implements: #1495

Related Issues

• once this is merged and released, also merge the depending PR in verified-sources: rest_api: Renames JSONResponsePaginator to JSONLinkPaginator. verified-sources#523

[netlify]

✅ Deploy Preview for dlt-hub-docs ready!

Name	Link
🔨 Latest commit	982d324
🔍 Latest deploy log	https://app.netlify.com/sites/dlt-hub-docs/deploys/668fd35ef538290008a65998
😎 Deploy Preview	https://deploy-preview-1558--dlt-hub-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rudolfix]

Looks good but this is a breaking change so what we need is

• JSONResponsePaginator as an alias or derive it directly from JSONLinkPaginator
• deprecate it, I think you can deprecate classes

what are you planning to do with rest_api? will it continue to work with old dlt or you will bump the required version?

[burnash]

@willi-mueller Looks good, I agree with @rudolfix we need to deprecate JSONResponsePaginator,

@rudolfix will something like this work?

import warnings

class JSONLinkPaginator(BaseNextUrlPaginator):
    ...


class JSONResponsePaginator(JSONLinkPaginator):
    def __init__(self):
        warnings.warn("JSONResponsePaginator is deprecated and will be removed in version 1.0.0. Use JSONLinkPaginator instead.", DeprecationWarning, stacklevel=2)
        super().__init__()

[burnash]

Great work, let's also deprecate the old class. See the comment above.

[willi-mueller]

Great work, let's also deprecate the old class. See the comment above.

Thanks! I marked the old class as deprecated and rebased onto devel.

I also bumped the dlt dependency in the verified-sources because in this repo, verified-sources, the docs, examples, and tests use the new, unmerged, and thus unreleased class name.

[burnash]

Looks good! Thank you @willi-mueller

we implemented the suggestions.