RESTClient: stops pagination after empty page (Feat/1637) #1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
willi-mueller
changed the title
willi-mueller
changed the title
burnash
previously approved these changes
Aug 15, 2024
Collaborator
burnash
left a comment
burnash
left a comment
There was a problem hiding this comment.
Great work, @willi-mueller. I've left a couple of comments
Co-authored-by: Anton Burnashev <[email protected]>
… None and [] as "no data"
burnash
approved these changes
Aug 19, 2024
Collaborator
burnash
left a comment
burnash
left a comment
There was a problem hiding this comment.
Awesome work, thank you @willi-mueller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RangePaginatorand its subclassesOffsetPaginatorandPageNumberPaginatorto stop pagination upon receiving a page without data itemsRangePaginatornow requires eithertotal_pathormaximum_offsetorstop_after_empty_pagetotal_pathis not provided, pagination is controlled bymaximum_pageandstop_after_empty_pageormaximum_offsetandstop_after_empty_pagerespectively.Related Issues