Enable scd2 record reinsert
#1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
jorritsandbrink
commented
Aug 19, 2024
| SELECT {col_str}, {boundary_ts} AS {from_}, {active_record_literal} AS {to} | ||
| FROM {staging_root_table_name} AS s | ||
| WHERE {hash_} NOT IN (SELECT {hash_} FROM {root_table_name}); | ||
| WHERE {hash_} NOT IN (SELECT {hash_} FROM {root_table_name} WHERE {is_active_clause}); |
Collaborator
Author
There was a problem hiding this comment.
This change enables reinsertion of a record if there is no active version of that record in the destination table.
One possible issue: users might have a UNIQUE constraint on the _dlt_id column in their existing scd2 tables. This will cause a uniqueness error. Those users would have to drop those constraints manually when upgrading to a newer version of dlt.
rudolfix
approved these changes
Aug 21, 2024
Collaborator
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
LGTM! also thanks for the docs update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scd2uniqueconstraint on_dlt_idin root tables (except when users bring their own hash)Related Issues
Fixes #1683