QoL: improve DataValidationError output: use identifying columns if present #2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djudjuu
commented
Jul 22, 2025
djudjuu
commented
- Fixes Show offending item in logs when schema_contract is set to "freeze" #1772
✅ Deploy Preview for dlt-hub-docs canceled.
|
djudjuu
commented
Jul 22, 2025
| for x in table_schema.get("columns", {}).values() | ||
| if x.get("primary_key") or x.get("merge_key") or x.get("unique") | ||
| ] | ||
| if identifier_columns: |
Contributor
Author
There was a problem hiding this comment.
i decided to not show any information about the data item if there is no info on what columns are relevant.
I was thinking to maybe do str(data_item.get("first_column_name")[:50] or something like that but it seemed a bit risky to me. what if the column is super huge or is bytes or whatnot?
djudjuu
commented
Jul 22, 2025
djudjuu
changed the title
djudjuu
force-pushed
the
QoL/1772/show-offending-item-in-logs-when-schema_contract-is-set-to-freeze
branch
from
89a50d5 to
5070ffd
Compare
anuunchin
requested changes
Jul 30, 2025
anuunchin
reviewed
Aug 1, 2025
AyushPatel101
pushed a commit
to AyushPatel101/dlt
that referenced
this pull request
Aug 8, 2025
…resent (dlt-hub#2915) * improve DataValidationError output: use identifying columns if present * removing duplicate `schema: {schema_name}` from error message * refactor
rudolfix
deleted the
QoL/1772/show-offending-item-in-logs-when-schema_contract-is-set-to-freeze
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.