Skip to content

Conversation

@sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Aug 5, 2025

Description

When running dlt from a folder that has a dot as the first character, def import_run_dir_module will fail with a TypeError because the import is interpreted as relative due to the dot. This PR ignores this error.

@netlify
Copy link

netlify bot commented Aug 5, 2025

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 59190e7
🔍 Latest deploy log https://app.netlify.com/projects/dlt-hub-docs/deploys/6891fff40ad0a90008b793ad

@sh-rp sh-rp changed the title fix failing top level module imports fix failing top level module imports on projects in dirs that start with a dot Aug 5, 2025
@sh-rp sh-rp marked this pull request as ready for review August 5, 2025 12:58
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit dc0ab55 into devel Aug 5, 2025
60 of 61 checks passed
@rudolfix rudolfix deleted the fix/ignore_failing_base_module_imports branch August 5, 2025 14:38
AyushPatel101 pushed a commit to AyushPatel101/dlt that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants