Jinso o fix/cors playground #2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace REST demo with DummyJSON users (CORS-safe for Playground)
- Switch from dummyjson to JSONPlaceholder users API - Add dev_mode=True for better development experience - Fix function parameter (remove unused dlt parameter) - Update table references from 'items' to 'users' consistently - Fix test assertion to expect 10 users instead of 50 - Add write_disposition='replace' to prevent data duplication - Improve data display with proper return statements
✅ Deploy Preview for dlt-hub-docs canceled.
|
AstrakhantsevaAA
requested changes
Aug 11, 2025
| # NOTE: this cell is only needed for testing this notebook on ci | ||
| assert pipeline.dataset().items.df().shape[0] == 50 | ||
| count = pipeline.dataset().users.df().shape[0] | ||
| if count != 10: |
Contributor
There was a problem hiding this comment.
use assert, there is how to add a proper error message: https://realpython.com/python-assert-statement/
AstrakhantsevaAA
requested changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated and edited by removinh problematic sqlite3 micropip install causing linting failure
Related Issues
#2975
Additional Context