Docs: Education notebooks formatted and linted #3017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
anuunchin
force-pushed
the
feat/ed-content-lint
branch
3 times, most recently
from
79ddf09 to
47b8f6f
Compare
anuunchin
force-pushed
the
feat/ed-content-lint
branch
from
47b8f6f to
0ff908c
Compare
zilto
previously requested changes
Aug 26, 2025
Collaborator
zilto
left a comment
zilto
left a comment
There was a problem hiding this comment.
Remove uv.lock. Otherwise, everything seems good
sh-rp
requested changes
Sep 1, 2025
Collaborator
sh-rp
left a comment
sh-rp
left a comment
There was a problem hiding this comment.
I have on suggestion, maybe remove the special chars from the filenames, such as "&", you can replace that with "and". And maybe it would be nice to have all files names lowercase? I'm thinking about this case where we launch these notebooks directly from the repo version. WDYT?
anuunchin
force-pushed
the
feat/ed-content-lint
branch
3 times, most recently
from
0c7f8cf to
95576c0
Compare
sh-rp
previously approved these changes
Sep 1, 2025
anuunchin
force-pushed
the
feat/ed-content-lint
branch
from
95576c0 to
5507f6e
Compare
anuunchin
force-pushed
the
feat/ed-content-lint
branch
4 times, most recently
from
47a53c5 to
d1818da
Compare
anuunchin
force-pushed
the
feat/ed-content-lint
branch
from
d1818da to
652aac8
Compare
sh-rp
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats and lints education content and is the second PR in the series of PRs related to moving educational notebooks to OSS.
Linting:
nbqawas used that creates temporary.pyfiles from the.ipynbones, so that flake and mypy can properly handle notebook files.Formatting:
blackwhich has ajupyterextension.Relates to #2969.