fix/3165 Athena LakeFormation permissions are required even tho Lakeformation is not used #3271
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 62eed5d | Commit Preview URL Branch Preview URL |
Nov 06 2025, 02:47 PM |
alkaline-0
force-pushed
the
fix/3165-athena-lakeformation-permissions-required-when-not-set
branch
2 times, most recently
from
e78bbf6 to
bdaa57f
Compare
sh-rp
left a comment
sh-rp
left a comment
There was a problem hiding this comment.
The fix looks good, small changes to the tests are needed
tests/load/pipeline/test_athena.py
Outdated
| def test_athena_lakeformation_config_gating( | ||
| destination_config: DestinationTestConfiguration, mocker | ||
| ) -> None: | ||
| pytest.importorskip("pyathena") |
There was a problem hiding this comment.
This should not be needed. This test is only selected when the athena destination is active(see destination_config setup above) and in that case, the athena extra will also be present.
| destinations_configs(default_sql_configs=True, subset=["athena"]), | ||
| ids=lambda x: x.name, | ||
| ) | ||
| def test_athena_lakeformation_config_gating( |
There was a problem hiding this comment.
I think these kind of tests are "more secure" if you parametrize them to have one run with lf enabled and check that the mocked function is called and then one run where it is not and thus the mocked function is not called
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
LGTM! this type of test is sufficient - clearly we deal with configuration problem, not edge behavior of athena
…d on configuration. Add tests to ensure tags are not applied when Lake Formation config is not set. This fixes the bug of lakeformation GetResourceLFTags bug
…rmation gating configuration. Update test to ensure proper mocking of connection methods.
… tests for Athena Lake Formation configuration.
alkaline-0
force-pushed
the
fix/3165-athena-lakeformation-permissions-required-when-not-set
branch
from
bdaa57f to
62eed5d
Compare
alkaline-0
deleted the
fix/3165-athena-lakeformation-permissions-required-when-not-set
branch
Description
Related Issues
Changes: