clones command repos in global_dir & bumps to 1.18.2 #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | cbe9e07 | Commit Preview URL Branch Preview URL |
Nov 03 2025, 10:19 AM |
sh-rp
approved these changes
Nov 3, 2025
| from dlt.common.runtime.telemetry import with_telemetry | ||
| from dlt.common.storages.file_storage import FileStorage | ||
|
|
||
| from dlt._workspace.profile import LOCAL_PROFILES |
Collaborator
There was a problem hiding this comment.
As far as I can see, this variable is never used anywhere in dlt, so you can also delete it from profile.py
Collaborator
Author
There was a problem hiding this comment.
let's keep them for now. I planned additional warnings when you delete data in profile that is not "local"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clones command repos in global_dir & bumps to 1.18.2