Skip to content

Conversation

@martinibach
Copy link
Contributor

@martinibach martinibach commented Nov 12, 2025

Description

  • Fix: Docs were not showing footer links properly in dark mode
  • Fix: Copyright was not aligned in design with footer
  • Add links to dlthub.com/workspace scaffoldings in footer
  • Add instructions in docs/webiste/Readme.md after running into python setup issues when running it for first time

Before:
Screenshot 2025-11-12 at 13 36 40

After:
Screenshot 2025-11-12 at 13 52 25

Screenshot 2025-11-12 at 13 52 33

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

@martinibach martinibach marked this pull request as ready for review November 12, 2025 13:01
@martinibach martinibach changed the title fix footer in darkmode, add scaffoldigns link [Docs] fix footer in darkmode, add scaffoldigns link Nov 12, 2025
@martinibach martinibach changed the title [Docs] fix footer in darkmode, add scaffoldigns link Docs: fix footer in darkmode, add scaffoldigns link Nov 12, 2025
Copy link
Contributor

@VioletM VioletM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing staff!

"resolved": "https://registry.npmjs.org/@algolia/client-search/-/client-search-5.37.0.tgz",
"integrity": "sha512-DAFVUvEg+u7jUs6BZiVz9zdaUebYULPiQ4LM2R4n8Nujzyj7BZzGr2DCd85ip4p/cx7nAZWKM8pLcGtkTRTdsg==",
"license": "MIT",
"peer": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, could you, please, explain why this file has been changed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran nvm install --lts and then npm install for you to reproduce

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, if you don't change the dependencies, it shouldn't change, probably? I'm not sure
Asking @sh-rp, he knows more!

@VioletM VioletM requested a review from sh-rp November 12, 2025 13:09
@VioletM VioletM merged commit 4224e88 into dlt-hub:devel Nov 14, 2025
15 checks passed
@zilto zilto mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants