Fix: pipeline_drop.__init__() got an unexpected keyword argument 'no_pwd' #3386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuunchin
commented
Nov 26, 2025
| state_paths=command_kwargs.get("state_paths", ()), | ||
| drop_all=command_kwargs.get("drop_all", False), | ||
| state_only=command_kwargs.get("state_only", False), | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
We could also inspect the signature of pipeline_drop and make this more dynamic 👀
rudolfix
approved these changes
Nov 26, 2025
Collaborator
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
LGTM! thanks for fixing this and the test
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 1b6ac4d | Commit Preview URL Branch Preview URL |
Nov 26 2025, 11:18 AM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just explicitly passes the required keyword arguments to the
drop_pipeline. Previously, global arguments that were being passed upstream were causing an unexpected argument error.Resolved #3379