fix: 3276 - toggling dev_mode doesn't reset dataset_name causing inconsistencies of dataset naming behavior when creating a pipeline without dev_mode #3404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | eff8cc5 | Commit Preview URL Branch Preview URL |
Nov 30 2025, 04:30 PM |
- Introduced `dev_mode` attribute in TPipelineLocalState to track development mode status. - Implemented logic to recreate initial pipeline state when toggling between dev and non-dev modes. - Updated dataset name generation to ensure consistency based on the current mode. - Added tests to verify dataset name behavior in different modes.
alkaline-0
force-pushed
the
fix/3276-maintain-dataset-name-consistency-in-relation-to-dev-mode
branch
from
1af9e7d to
8436348
Compare
- Updated the `_recreate_initial_state` method to clear the injected state dictionary before applying default values. - Enhanced type casting for better clarity and safety in state management. - Added assertions in tests to verify the state is correctly reset in development mode.
alkaline-0
force-pushed
the
fix/3276-maintain-dataset-name-consistency-in-relation-to-dev-mode
branch
from
e96c9f6 to
81f0653
Compare
- Introduced `_get_prev_dev_mode_from_state` method to read the development mode from the raw state.json, ensuring compatibility with engine versions. - Updated `_configure` method to utilize the new method for determining previous dev_mode status. - Enhanced pipeline state migration to include dev_mode and initial working directory in the local state for engine version upgrades.
alkaline-0
force-pushed
the
fix/3276-maintain-dataset-name-consistency-in-relation-to-dev-mode
branch
from
57d02a6 to
2294535
Compare
…t is always updated after pipeline creation.
alkaline-0
force-pushed
the
fix/3276-maintain-dataset-name-consistency-in-relation-to-dev-mode
branch
2 times, most recently
from
c702c51 to
5e729c9
Compare
alkaline-0
force-pushed
the
fix/3276-maintain-dataset-name-consistency-in-relation-to-dev-mode
branch
from
5e729c9 to
eff8cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a pipeline runs with dev_mode=True, its dataset_name is suffixed with a unique pipeline_instance_id. On subsequent runs with dev_mode=False, the suffix could persist via restored state, causing:
Suggested solution
Implementation details
Add dev_mode to TPipelineLocalState.
Hard reset on dev→non-dev
In _configure, If _local["dev_mode"] was True and current self.dev_mode is False:
Issues
solves #3276