Skip to content

Conversation

@ivasio
Copy link
Contributor

@ivasio ivasio commented Dec 18, 2025

Changes in the testing setup

  • Added oracle, now oracle source tests can be added. Very basic set of tests is currently there, to be improved in other PRs
  • There's now 3 groups of "local source" tests running in a matrix in CI: those that use oracle, mssql or postgres/other sources. When adding new tests for the first 2 categories, mssql and oracle pytest marks should be used, e.g. like here

Oracle - current changes and plans

  • Currently, we're claiming we don't fully support oracledb driver in thin mode. The direction me and @rudolfix have chosen is to actually support it as much as we can and test/document the caveats. The older cx_Oracle has been deprecated for 3 years now in favour of oracledb, so we don't want to promote it's usage and don't test it
  • In this PR, an oracle extra has been added which installs only the oracledb driver. In fact, it's only usable with sqlalchemy>2, but I couldn't add this requirement to avoid the conflict with requirement groups defined in pyproject.toml
  • Documentation etc. to be added in separate PRs. This one is aimed to unlock the other ones in terms of testing setup

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
docs 7856c2f Commit Preview URL

Branch Preview URL
Dec 23 2025, 12:50 PM

@ivasio ivasio marked this pull request as ready for review December 22, 2025 16:36
@ivasio ivasio requested a review from sh-rp December 22, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants