This line:
|
return new std::string(os.str()); |
Returns a raw pointer of string, which is not collected. Although it happens only when fatal error occurs, but it's still a c++ exception which can be caught, so deleting it is necessary. Also, it breaks sanitizer tests.
This line:
dmlc-core/include/dmlc/logging.h
Line 171 in 9db4b20
Returns a raw pointer of string, which is not collected. Although it happens only when fatal error occurs, but it's still a c++ exception which can be caught, so deleting it is necessary. Also, it breaks sanitizer tests.