Fix broken snapshot testing #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syucream
commented
Dec 4, 2021
| }); | ||
| await waitForElementToBeRemoved(screen.getByTestId("loading")); |
There was a problem hiding this comment.
waitForElementToBeRemoved can wait async processes.
syucream
commented
Dec 4, 2021
| * NOTE It's a workaround for Material-UI v4 issue on snapshot testing. It works but make snapshot HTML not-human-readable. | ||
| * see also https://github.com/mui-org/material-ui/issues/21293#issuecomment-654921524 | ||
| */ | ||
| const modifiedHtml = container.innerHTML |
There was a problem hiding this comment.
TablePagination component generates random ids fails snapshot testing. For now it removes these ids from fragment.
mui/material-ui#21293
https://blog.shinki.net/posts/material-ui-testing-library-snapshot
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 101 101
Lines 5073 5073
Branches 1179 1179
=======================================
Hits 4398 4398
Misses 408 408
Partials 267 267 Continue to review full report at Codecov.
|
userlocalhost
approved these changes
Dec 7, 2021
hinashi
pushed a commit
to hinashi/airone
that referenced
this pull request
Sep 21, 2022
STACK-1896 Feature Source NAT flavor support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current snapshot doesn't contain content get by async API calls so this PR wait the calls, then assert rendered content.