Skip to content

Conversation

@pomadin
Copy link
Contributor

@pomadin pomadin commented Apr 16, 2019

Hi, I have created simple pull request for raised issue. I don't find rules or conventions on PR format, so created it this way.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #37   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         479    479           
  Branches       46     46           
=====================================
  Hits          479    479
Impacted Files Coverage Δ
packages/luxon/src/luxon-utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0dfb67...f1f1caa. Read the comment docs.

public dateTime24hFormat = "MMMM dd T";

public time12hFormat = "hh:mm a";
public time12hFormat = "t";
Copy link
Contributor Author

@pomadin pomadin Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, 12/24 time formats should follow the same rules, so both are localizable formats.
Therefore they should be specified

public time12hFormat = "t";
public time24hFormat = "T";

or

public time12hFormat = "hh:mm a";
public time24hFormat = "HH:mm";

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering that t and T for some locales can be super long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt, the luxon implementation is restricted by Intl API, where I cannot imagine a verbose format for time, due to { hour: n, minute: d2 } etc... Do you know a locale where it could be long?

@dmtrKovalenko dmtrKovalenko merged commit 17d40fa into dmtrKovalenko:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants