fix: correctly handle locale in parse #401
Conversation
| formats, | ||
| }: { formats?: Partial<DateIOFormats>; locale?: string } = {}) { | ||
| this.locale = locale || "en"; | ||
| this.locale = locale || "en-US"; |
There was a problem hiding this comment.
Because the default for luxon is en-US not en, adding the handling to pass through the locale to parse was breaking one of the non locale aware parse tests because it was changing it from en-US to en. Using en-US should ensure that the default behavior doesn't change at all
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 553 555 +2
Branches 64 65 +1
=========================================
+ Hits 553 555 +2
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| return DateTime.fromFormat(value, formatString); | ||
| return DateTime.fromFormat(value, formatString, { locale: this.locale }); |
There was a problem hiding this comment.
This fixes luxon
| } | ||
|
|
||
| if (this.locale) { | ||
| return this.moment(value, format, this.locale, true); |
There was a problem hiding this comment.
this fixes moment
I ran this, but it generated a bunch of changes in several different files. It seems like my prettier is getting different results than yours. The only thing I could think of that would cause that is differences in |
|
Thanks! |
3 participants
This makes sure that locale gets passed through to parse in Luxon and moment