Fix/add locale to parse #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 553 553
Branches 64 64
=========================================
Hits 553 553
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| return this.dayjs(value, format); | ||
| return this.dayjs(value, format, this.locale); |
Owner
There was a problem hiding this comment.
Are you sure this.locale is always defined? Will it crash if locale is not defined?
Owner
|
Tested and confirmed it works like a charm |
dmtrKovalenko
approved these changes
Jul 1, 2020
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes mui/material-ui-pickers#1895