Add diagnostics, derivative uniformity problems trigger diagnostics #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dneto0
force-pushed
the
issue-3554-diag
branch
3 times, most recently
from
a883fae to
3bd8914
Compare
Diagnostics may be "filtered" both globally and over a range of source text. A filter can drop a matching diagnostic, or change its severity level. Future versions of WGSL can drop a rule too. Created "diagnostic rule name" token class - They are spelled like identifier-like things but are not explicitly enumerated in the spec. Fixes: gpuweb#3554
Move definition of triggering location. Say that error maps to shader-creation and pipeline-creation errors. Add TODO's related to gpuweb#3682
- Detectable errors will generate diagnostics. - Most diagnostics are not filterable. They can only be so if triggered by one of a few enumerated filterable triggering rules. - Fix the description of where diagnostics go if processing during shader-creaiton or pipeline-creation.
Remove the case where the diagnostic filter applies to the *arguments* of the targeted call site. This is under dispute. See gpuweb#3689
dneto0
force-pushed
the
issue-3554-diag
branch
from
d8e6f60 to
4e4d729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics may be "filtered" both locally and globally. A filter can drop a matching diagnostic, or change its severity level.
Fixes: gpuweb#3554