Ignore dead code warning in preparation for flow analysis improvement. #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dart-lang/language#1274 (Infer non-nullability from local boolean variables) is implemented, flow analysis will detect that code like this is unreachable: bool hasArguments = false; ... if (hasArguments) { // Not reachable } To prepare for this improvement, we need to add an "ignore" comment to ignore the dead_code warning that will be generated.
dnfield
reviewed
Dec 17, 2020
lib/src/picture_provider.dart
Outdated
| @@ -159,7 +159,7 @@ class PictureConfiguration { | |||
| result.write('PictureConfiguration('); | |||
| bool hasArguments = false; | |||
| if (bundle != null) { | |||
| if (hasArguments) { | |||
| if (hasArguments) { // ignore: dead_code | |||
There was a problem hiding this comment.
But this isn't dead. Ok the subsequent iteration it's used.
dnfield
approved these changes
Dec 17, 2020
|
Ci failure is the coveralls issue which I really need to fix at some point. Tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dart-lang/language#1274 (Infer
non-nullability from local boolean variables) is implemented, flow
analysis will detect that code like this is unreachable:
To prepare for this improvement, we need to add an "ignore" comment to
ignore the dead_code warning that will be generated.