Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

LogPrinter should not be part of the API #1765

Merged
ndeloof merged 1 commit into from
Jun 9, 2021
Merged

LogPrinter should not be part of the API #1765

ndeloof merged 1 commit into from
Jun 9, 2021

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jun 9, 2021

What I did
Made logPrinter private in local backend, not relevant anymore on the API
Made watchContainers more flexible with onStart func which is responsible to get just-started container log stream

@ndeloof ndeloof requested review from lorenrh and ulyssessouza June 9, 2021 08:09
@github-actions github-actions bot added the local Local context (moby) label Jun 9, 2021
@ndeloof ndeloof merged commit 3202ab9 into docker-archive:main Jun 9, 2021
@ndeloof ndeloof deleted the log_printer branch June 9, 2021 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

1 more reviewer

@lorenrh lorenrh lorenrh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

local Local context (moby)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndeloof @lorenrh