This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Fix races #1901
Merged
Fix races #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Champlon <[email protected]>
This should fix concurrent accesses to the map. Signed-off-by: Mathieu Champlon <[email protected]>
Signed-off-by: Mathieu Champlon <[email protected]>
lorenrh
approved these changes
Jul 7, 2021
Contributor
lorenrh
left a comment
lorenrh
left a comment
There was a problem hiding this comment.
LGTM, but wouldn't mind another pair of eyes!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I made the code consistent regarding loop variables capture for gorountines (ultimately we should probably use functions to split the code?). Also some variable copies before goroutines were missing.
I also serialized accesses to a map following crashes with «concurrent map read and map write» panics.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did