Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Conversation

@amineck
Copy link

@amineck amineck commented Jul 22, 2021

What I did

  • Add a post-login message to promote Personal Access Tokens https://docs.docker.com/docker-hub/access-tokens/
  • Message will only appear if:
    1- User is using default registry
    2- User successfully logged in
    3- User is not using a Personal Access Token
> docker login -u amineck
Password:
Login Succeeded

Logging in with your password grants your terminal complete access to your account.
For better security, log in with a limited-privilege personal access token. Learn more at https://docs.docker.com/docker-hub/access-tokens/

@github-actions github-actions bot added the cli cli label Jul 22, 2021
Copy link
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a compose-cli only "feature", i.e. not intended to move into compose.v2, pat_suggest.go should not be part of pkg and could just be hosted within cli package

@amineck
Copy link
Author

amineck commented Jul 23, 2021

@amineck amineck requested a review from ndeloof July 23, 2021 15:02
@ndeloof ndeloof merged commit de6bdd4 into docker-archive:main Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cli cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants