use docker run --link option to link a new cassandra node to another #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems sane, but I would rather use 'cassandra' as the value if there is a link, so that when the linked container is restarted it can use the updated |
|
👍 sounds good! This PR already add value to the container in that state. I need to test with cassandra hostname. Implementation may bit a bit different to check if link is used then use cassandra hostname but it is easy to do. |
|
🏁 update branch and testing done. Seems ok with your proposal! |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Aug 13, 2015
use docker run --link option to link a new cassandra node to another
|
Thanks, I send a PR to update the documentation here: docker-library/docs#303 Could someone take a look ? Bye |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 17, 2015
- `cassandra`: `--link` for seeding (docker-library/cassandra#21) - `drupal`: update Drupal 7 to use PHP 5.6 (docker-library/drupal#9) - `elasticsearch`: minor template updates (docker-library/elasticsearch#45) - `logstash`: add 1.4 as a supported version (docker-library/logstash#21) - `mariadb`: add `initdb` directory support (MariaDB/mariadb-docker#18) - `owncloud`: 8.0.6, caching modules (docker-library/owncloud#16) - `percona`: add `initdb` directory support (docker-library/percona#6)
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `cassandra`: `--link` for seeding (docker-library/cassandra#21) - `drupal`: update Drupal 7 to use PHP 5.6 (docker-library/drupal#9) - `elasticsearch`: minor template updates (docker-library/elasticsearch#45) - `logstash`: add 1.4 as a supported version (docker-library/logstash#21) - `mariadb`: add `initdb` directory support (MariaDB/mariadb-docker#18) - `owncloud`: 8.0.6, caching modules (docker-library/owncloud#16) - `percona`: add `initdb` directory support (docker-library/percona#6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am using this image to setup a spark+cassandra cluster and I was wondering if we could use the docker run --link option to link new node to the first one instead of docker inspect command value pass to an environnement variable.
With this change, adding a node to the cluster is simpler, isn't it ?
WDYT? sorry if I am wrong, I am neither a docker expert, nor a C* one ;-)