Skip to content

Clarify Dart getting started steps #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

mit-mit
Copy link
Contributor

@mit-mit mit-mit commented Oct 25, 2021

Based on feedback in dart-lang/dart-docker#28

@mit-mit
Copy link
Contributor Author

mit-mit commented Oct 25, 2021

cc @athomas & @kevmoo can you please review?

@mit-mit mit-mit changed the title Clarify getting started steps Clarify Dart getting started steps Oct 25, 2021
dart/content.md Outdated
$ dart create -t server-shelf myserver
```

### Running server with Docker Desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the server or a server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yilmazdurmaz
Copy link

yilmazdurmaz commented Nov 24, 2021

@athomas @mit-mit

thanks for this addition.

a little problem though: the command seems pretty new. I use dart 2.13.3 which is an installation no older than 6 months, in it the command template is "server-simple" not "server-shelf".

can you include dart version info too? a minimum maybe? or maybe give both commands if both are applicable in docker.

Edit: I found out now though "server-simple" exists older, that template does not have a docker file in it. so one has to write a dockerfile manually before "docker build" command. If you decide to also add "server-simple" then a guard clause like "check Image documentation below" would be nice.

@mit-mit
Copy link
Contributor Author

mit-mit commented Nov 24, 2021

@yilmazdurmaz
Copy link

@mit-mit about dart versions, you have more knowledge than I may possible cant have for another year :)

if server-shelf came out when 2.14 did (so specific minor version) then that edit is fine.

as for server-simple. I saw this stagehand replaced by dart create somewhere in near history. I don't know of those dates. I just happened to have version 2.13 and there the template name is different and it does not have dockerfile in it.

and in that case, this docker document has a dockerfile content documented down below that same page.

so maybe adding something like this helps:

"for older versions of dart, create your dart server project, add a dockerfile and refer to the dockerfile image documentation down below (eg. template name is server-simple in version 2.13 )"

@mit-mit
Copy link
Contributor Author

mit-mit commented Nov 24, 2021

if server-shelf came out when 2.14 did (so specific minor version) then that edit is fine.

It did.

As for server-simple. I saw this stagehand replaced by dart create somewhere in near history.

Yes, that also happened in 2.14: dart-lang/sdk#46100

"for older versions of dart"

We don't generally document past stable releases as we're still evolving quite a bit, so this quickly get's unsustainable.

Thanks for the feedback! I'll get that new PR landed.

@mit-mit mit-mit deleted the patch-1 branch November 24, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants