Skip to content

Add documenation of /docker-entrypoint-initdb.d #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2014
Merged

Add documenation of /docker-entrypoint-initdb.d #71

merged 1 commit into from
Oct 9, 2014

Conversation

md5
Copy link
Contributor

@md5 md5 commented Oct 9, 2014

@yosifkit
Copy link
Member

yosifkit commented Oct 9, 2014

Thanks for the contributions.
One minor nitpick, can you reflow to 80 columns? (vim, :set tw=80, retype last character)

Otherwise, LGTM, cc @tianon

@md5
Copy link
Contributor Author

md5 commented Oct 9, 2014

The reason I left the long line in my addition was that the rest of the file already had unwrapped lines. I don't mind reflowing the whole file if that's what you want though.

@yosifkit
Copy link
Member

yosifkit commented Oct 9, 2014

Oh, no problem, this one had not yet had the flowing. You can leave it without the wrapping. I'll work on a PR once we merge this that will reflow all the files that need it.

@tianon
Copy link
Member

tianon commented Oct 9, 2014

So much gushing. This is beautiful, and even includes a link to upstream's documentation with hints about how to make really cool changes easily. Rock on, man.

LGTM

tianon added a commit that referenced this pull request Oct 9, 2014
Add documenation of /docker-entrypoint-initdb.d
@tianon tianon merged commit d831273 into docker-library:master Oct 9, 2014
@md5
Copy link
Contributor Author

md5 commented Oct 9, 2014

🤘

@md5 md5 deleted the postgres-entrypoint-initdb branch October 9, 2014 21:15
@tianon
Copy link
Member

tianon commented Oct 9, 2014

As a side note, are you in #docker-library on Freenode? :)

(You seem really interested in the Postgres image, so I'd love to have you
around more often so we can make use of your thoughts, and maybe consider
some co-maintenance if you're interested in such a thing. ;))

@md5
Copy link
Contributor Author

md5 commented Oct 10, 2014

I'm not on IRC all that much. Usually only when I'm impatient about getting a question answered and think that's where I can find the developers of a project I'm using.

As for my interest in the Postgres image, I'm primarily working right now on a POC of running iNaturalist.org under Docker. I need to get a solid Postgres image with Postgis functionality to make that happen, among other bits I've yet to work out.

@tianon
Copy link
Member

tianon commented Oct 15, 2014

Aww, fair enough. At least you know you have our love and appreciation. ♥

ypid pushed a commit to ypid/docker-docs that referenced this pull request Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants