-
Notifications
You must be signed in to change notification settings - Fork 343
Closed
Description
Currently this could happen:
- I set elasticsearch up on a docker host in my production environment using the image from dockerhub. Works fine.
- Someone makes a breaking change in github without my knowledge and publishes it to dockerhub, overwriting the image that I had previously pulled down. IE it may pass their tests but fail for my configuration.
- Production server restarts for some reason. Docker, noticing that the remote version with the same tag is different, pulls down the latest version with the breaking change, breaking the production server.
This happened to me recently when using the 'official' rmq dockerhub image, so now we keep our own version in our own docker repo - I'd prefer not to have to do this though.
A way around it would be to use tags that indicate the version on github, either an explicit version or commit hash. This way when someone does a change in github, it will be reflected in dockerhub.
The tags used in dockerhub could be something like 2.2 (elasicsearch version) - a4fe2 (dockerfile commit hash)
What do ye think about this?
Metadata
Metadata
Assignees
Labels
No labels