Only be root when necessary, so that --user works
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,10 +8,13 @@ if [ "${1:0:1}" = '-' ]; then | |||
| fi | |||
|
|
|||
| # Drop root privileges if we are running elasticsearch | |||
| if [ "$1" = 'elasticsearch' ]; then | |||
| # allow the container to be stated with `--user` | |||
|
LGTM |
|
Comment typo fixed in a3f8e65 |
tianon
added a commit
that referenced
this pull request
Jan 18, 2016
Only be root when necessary, so that `--user` works
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jan 18, 2016
- `elasticsearch`: allow `--user` (docker-library/elasticsearch#77) - `java`: 9~b101-2 - `rocket.chat`: 0.14.0 (and reorder a bit; RocketChat/Docker.Official.Image@72ee51e...af3284f)
This was referenced Jan 21, 2016
how do you skip entrypoint? |
|
|
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `elasticsearch`: allow `--user` (docker-library/elasticsearch#77) - `java`: 9~b101-2 - `rocket.chat`: 0.14.0 (and reorder a bit; RocketChat/Docker.Official.Image@72ee51e...af3284f)
1gtm
pushed a commit
to appscode-images/elasticsearch
that referenced
this pull request
Feb 14, 2024
This commit was created by the elastic-dockerfiles-publisher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user mounts a directory to
/usr/share/elasticsearch/data, while using--useron thedocker runthen they are responsible to set the permissions. This should also help OSX users when sharing a directory from the host:$ docker run -d -v /Users/...elasticsearch/:/usr/share/elasticsearch/data --user 1000:50 elasticsearchresolves #14 fixes #27 fixes #69 fixes #74
Caveat: to run
elasticsearchasroot, you will have to skip the entrypoint.