Skip to content

Commit 8ca1e9a

Browse files
authored
Merge pull request #213 from nogoegst/remove-nopic-patch
Remove obsolete no-pic.patch from alpine images
2 parents 5ec16dd + 8dca7d7 commit 8ca1e9a

File tree

8 files changed

+13
-53
lines changed

8 files changed

+13
-53
lines changed

1.10/alpine3.7/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ RUN apk add --no-cache ca-certificates
44

55
ENV GOLANG_VERSION 1.10.1
66

7-
# no-pic.patch: https://golang.org/issue/14851 (Go 1.8 & 1.7)
8-
COPY *.patch /go-alpine-patches/
7+
# make-sure-R0-is-zero-before-main-on-ppc64le.patch: https://github.com/golang/go/commit/9aea0e89b6df032c29d0add8d69ba2c95f1106d9 (Go 1.9)
8+
#COPY *.patch /go-alpine-patches/
99

1010
RUN set -eux; \
1111
apk add --no-cache --virtual .build-deps \

1.10/alpine3.7/no-pic.patch

Lines changed: 0 additions & 16 deletions
This file was deleted.

1.9/alpine3.6/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ RUN apk add --no-cache ca-certificates
44

55
ENV GOLANG_VERSION 1.9.5
66

7-
# no-pic.patch: https://golang.org/issue/14851 (Go 1.8 & 1.7)
7+
# make-sure-R0-is-zero-before-main-on-ppc64le.patch: https://github.com/golang/go/commit/9aea0e89b6df032c29d0add8d69ba2c95f1106d9 (Go 1.9)
88
COPY *.patch /go-alpine-patches/
99

1010
RUN set -eux; \

1.9/alpine3.6/no-pic.patch

Lines changed: 0 additions & 16 deletions
This file was deleted.

1.9/alpine3.7/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ RUN apk add --no-cache ca-certificates
44

55
ENV GOLANG_VERSION 1.9.5
66

7-
# no-pic.patch: https://golang.org/issue/14851 (Go 1.8 & 1.7)
7+
# make-sure-R0-is-zero-before-main-on-ppc64le.patch: https://github.com/golang/go/commit/9aea0e89b6df032c29d0add8d69ba2c95f1106d9 (Go 1.9)
88
COPY *.patch /go-alpine-patches/
99

1010
RUN set -eux; \

1.9/alpine3.7/no-pic.patch

Lines changed: 0 additions & 16 deletions
This file was deleted.

Dockerfile-alpine.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ RUN apk add --no-cache ca-certificates
44

55
ENV GOLANG_VERSION %%VERSION%%
66

7-
# no-pic.patch: https://golang.org/issue/14851 (Go 1.8 & 1.7)
7+
# make-sure-R0-is-zero-before-main-on-ppc64le.patch: https://github.com/golang/go/commit/9aea0e89b6df032c29d0add8d69ba2c95f1106d9 (Go 1.9)
88
COPY *.patch /go-alpine-patches/
99

1010
RUN set -eux; \

update.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,14 @@ for version in "${versions[@]}"; do
112112
;;
113113
esac
114114

115+
(
116+
shopt -s nullglob
117+
variantPatches=( "$version/$variant/"*.patch )
118+
if [ "${#variantPatches[@]}" -eq 0 ]; then
119+
sed -ri 's/^COPY.*patch/#&/' "$version/$variant/Dockerfile"
120+
fi
121+
)
122+
115123
travisEnv='\n - VERSION='"$version VARIANT=$variant$travisEnv"
116124
fi
117125
done

0 commit comments

Comments
 (0)