Skip to content

Remove obsolete no-pic.patch from alpine images #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

unkaktus
Copy link
Contributor

It was necessary for Go < 1.9. Now there are only 1.9 and 1.10 so we don't need this patch anymore.

@unkaktus unkaktus force-pushed the remove-nopic-patch branch from 1271a73 to dc93303 Compare March 17, 2018 22:36
@tianon tianon force-pushed the remove-nopic-patch branch from dc93303 to 5d2c2fd Compare April 9, 2018 17:41
@tianon
Copy link
Member

tianon commented Apr 9, 2018

I've successfully verified this against github.com/mattes/migrate/cli, which is the example that was failing in golang/go#14851. 👍

(For future reference, this was added in #91.)

@tianon
Copy link
Member

tianon commented Apr 9, 2018

(Once Travis is happy, we're good to merge. 👍)

@tianon tianon merged commit 8ca1e9a into docker-library:master Apr 9, 2018
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 10, 2018
- `golang`: remove `no-pic.patch` (docker-library/golang#213)
- `haproxy`: 1.8.7
- `hello-seattle`, `hello-world`, `hola-mundo`: swap Docker Cloud links for Docker Hub (docker-library/hello-world#46)
- `redmine`: 3.4.5, 3.3.7
- `rocket.chat`: 0.63.1
- `tomcat`: replace SHA1 with SHA512 (docker-library/tomcat#116)
davidl-zend pushed a commit to davidl-zend/official-images that referenced this pull request Apr 17, 2018
- `golang`: remove `no-pic.patch` (docker-library/golang#213)
- `haproxy`: 1.8.7
- `hello-seattle`, `hello-world`, `hola-mundo`: swap Docker Cloud links for Docker Hub (docker-library/hello-world#46)
- `redmine`: 3.4.5, 3.3.7
- `rocket.chat`: 0.63.1
- `tomcat`: replace SHA1 with SHA512 (docker-library/tomcat#116)
davidl-zend pushed a commit to davidl-zend/official-images that referenced this pull request Apr 17, 2018
- `golang`: remove `no-pic.patch` (docker-library/golang#213)
- `haproxy`: 1.8.7
- `hello-seattle`, `hello-world`, `hola-mundo`: swap Docker Cloud links for Docker Hub (docker-library/hello-world#46)
- `redmine`: 3.4.5, 3.3.7
- `rocket.chat`: 0.63.1
- `tomcat`: replace SHA1 with SHA512 (docker-library/tomcat#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants