Skip to content

Pass extra mysqld flags to mysql_install_db #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

tianon
Copy link
Member

@tianon tianon commented Dec 21, 2017

Fixes #356

I've tested and verified this with --datadir=/data/db --innodb-log-file-size=1G specified at runtime, and everything works (on both mysql:5.5 and mysql:5.6), with the appropriate and expected output from mysql_install_db while initializing InnoDB:

...
171221 21:35:35  InnoDB: Setting file ./ibdata1 size to 10 MB
InnoDB: Database physically writes the file full: wait...
171221 21:35:35  InnoDB: Log file ./ib_logfile0 did not exist: new to be created
InnoDB: Setting log file ./ib_logfile0 size to 1024 MB
InnoDB: Database physically writes the file full: wait...
InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000
MySQL init process in progress...
MySQL init process in progress...
171221 21:35:37  InnoDB: Log file ./ib_logfile1 did not exist: new to be created
InnoDB: Setting log file ./ib_logfile1 size to 1024 MB
InnoDB: Database physically writes the file full: wait...
InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000
MySQL init process in progress...
...

@tianon
Copy link
Member Author

tianon commented Dec 21, 2017

(Used a custom --datadir in my testing to verify that this doesn't break any of that functionality, and I also verified that the containers were in fact writing to /data/db as a result.)

@yosifkit yosifkit merged commit 9812fd1 into docker-library:master Dec 21, 2017
@yosifkit yosifkit deleted the extra-mysqld-flags branch December 21, 2017 21:59
tianon added a commit to infosiftr/stackbrew that referenced this pull request Dec 23, 2017
- `mariadb`: 10.1.30
- `mysql`: pass extra `mysqld` flags to `mysql_install_db` (docker-library/mysql#358)
- `nextcloud`: redis 3.1.5 (nextcloud/docker#205)
- `ruby`: bundler 1.16.1
- `wordpress`: adjust hard-coded `www-data` to allow for arbitrary user support (docker-library/wordpress#249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants