Revert to not using daemonize flag for temporary startup of 5.7 server #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daemonize lets us avoid a manual wait loop for the server to be ready, but for 5.7 it causes a log redirection error when the image is started with -t, so for now just revert 5.7 image to using the wait loop.
|
LGTM, but we do need to run |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 16, 2019
Changes: - docker-library/mysql@75f81c8: Merge pull request docker-library/mysql#601 from ltangvald/fixtty - docker-library/mysql@6659750: Apply update.sh - docker-library/mysql@4efd127: Revert to not using daemonize flag for temporary startup of 5.7 server
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daemonize lets us avoid a manual wait loop for the server to be ready, but
for 5.7 it causes a log redirection error when the image is started with -t,
so for now just revert 5.7 image to using the wait loop.