Skip to content

Add "suite aliases" ("-oraclelinux8", "-bullseye", etc) #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

tianon
Copy link
Member

@tianon tianon commented Jul 3, 2023

Closes #980

Diff:
$ diff -u --color <(bashbrew cat mysql) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63	2023-07-03 14:47:19.088329349 -0700
+++ /dev/fd/62	2023-07-03 14:47:19.088329349 -0700
@@ -1,23 +1,23 @@
 Maintainers: Tianon Gravi <[email protected]> (@tianon), Joseph Ferguson <[email protected]> (@yosifkit)
 GitRepo: https://github.com/docker-library/mysql.git
 
-Tags: 8.0.33, 8.0, 8, latest, 8.0.33-oracle, 8.0-oracle, 8-oracle, oracle
+Tags: 8.0.33, 8.0, 8, latest, 8.0.33-oraclelinux8, 8.0-oraclelinux8, 8-oraclelinux8, oraclelinux8, 8.0.33-oracle, 8.0-oracle, 8-oracle, oracle
 Architectures: amd64, arm64v8
 GitCommit: 1bfa4724fe112b4246672ed2b3c42142f17d5636
 Directory: 8.0
 File: Dockerfile.oracle
 
-Tags: 8.0.33-debian, 8.0-debian, 8-debian, debian
+Tags: 8.0.33-bullseye, 8.0-bullseye, 8-bullseye, bullseye, 8.0.33-debian, 8.0-debian, 8-debian, debian
 GitCommit: 611aa464a96f69e5d4d4172b14ca829ded162b42
 Directory: 8.0
 File: Dockerfile.debian
 
-Tags: 5.7.42, 5.7, 5, 5.7.42-oracle, 5.7-oracle, 5-oracle
+Tags: 5.7.42, 5.7, 5, 5.7.42-oraclelinux7, 5.7-oraclelinux7, 5-oraclelinux7, 5.7.42-oracle, 5.7-oracle, 5-oracle
 GitCommit: e4bdff20153e6a05364a8fe80356dcfd502445bd
 Directory: 5.7
 File: Dockerfile.oracle
 
-Tags: 5.7.42-debian, 5.7-debian, 5-debian
+Tags: 5.7.42-buster, 5.7-buster, 5-buster, 5.7.42-debian, 5.7-debian, 5-debian
 GitCommit: 611aa464a96f69e5d4d4172b14ca829ded162b42
 Directory: 5.7
 File: Dockerfile.debian

@yosifkit
Copy link
Member

yosifkit commented Jul 3, 2023

Should these stick to the "full" Oracle Linux name like the openjdk tags do?

https://github.com/docker-library/official-images/blob/849f600bb19aeeea0bb0f5d022fb85780d9dc7d3/library/openjdk#L7

@tianon
Copy link
Member Author

tianon commented Jul 3, 2023

Oh, I thought we'd gone short there, but I can update.

@tianon tianon changed the title Add "suite aliases" ("-ol8", "-bullseye", etc) Add "suite aliases" ("-oraclelinux8", "-bullseye", etc) Jul 3, 2023
@tianon
Copy link
Member Author

tianon commented Jul 3, 2023

PR, title, and OP diff updated

@tianon
Copy link
Member Author

tianon commented Jul 3, 2023

@ltangvald does this seem pretty reasonable? anything about it you might change? 👀

@tianon
Copy link
Member Author

tianon commented Dec 15, 2023

I think we should probably merge this 👀

@yosifkit yosifkit merged commit c4a7f36 into docker-library:master Dec 15, 2023
@yosifkit yosifkit deleted the suite-aliases branch December 15, 2023 16:47
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 15, 2023
Changes:

- docker-library/mysql@c4a7f36: Merge pull request docker-library/mysql#981 from infosiftr/suite-aliases
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 15, 2023
Changes:

- docker-library/mysql@3728e57: Merge pull request docker-library/mysql#1018 from infosiftr/new-key
- docker-library/mysql@d035567: Add new upstream gpg key for Debian packages
- docker-library/mysql@c4a7f36: Merge pull request docker-library/mysql#981 from infosiftr/suite-aliases
martin-g pushed a commit to martin-g/docker-official-images that referenced this pull request Apr 3, 2024
Changes:

- docker-library/mysql@3728e57: Merge pull request docker-library/mysql#1018 from infosiftr/new-key
- docker-library/mysql@d035567: Add new upstream gpg key for Debian packages
- docker-library/mysql@c4a7f36: Merge pull request docker-library/mysql#981 from infosiftr/suite-aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named Debian builds
2 participants