Skip to content

Update Windows pins #18443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

Update Windows pins #18443

merged 2 commits into from
Feb 27, 2025

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 12, 2025

No description provided.

@docker-library-bot
Update mcr.microsoft.com/windows/nanoserver:ltsc2025 to sha256:d62954…
e33fac5 
…1ac36f4e051531123eee7226dbfcf55970298953fceef03bc378d31f2a
@docker-library-bot
Update mcr.microsoft.com/windows/servercore:ltsc2025 to sha256:44b288…
bb790aa 
…4c5db9f03d57b7494371706cf95d4345c75399c420e63b5f5609313ee6
@tianon tianon requested a review from a team as a code owner February 12, 2025 16:59
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@yosifkit
Copy link
Member

#18435 (comment):

The problem is that the windows-2025 runner is too old to run the mcr.microsoft.com/windows/servercore:ltsc2025 image released this week (actions/runner-images#11582). It should be fine for our builds since we pin to specific Windows images and can delay moving the 2025 pin until the GitHub runners are ready. This will mean that the Windows 2025 images will not get their "Patch Tuesday" rebuilds until the runner images are updated.

So, we need to not add the 2025 updates until the GitHub actions runner images are ready. Can you split this PR to exclude the 2025 updates?

@tianon tianon mentioned this pull request Feb 12, 2025
Merged
@tianon
Copy link
Member Author

tianon commented Feb 12, 2025

Yeah... 😭

#18447

(this is not a great situation to be in, but nothing we can do about it right now 😞)

@docker-library-bot docker-library-bot force-pushed the external-pins-mcr.microsoft.com branch from d38ec56 to dd08155 Compare February 13, 2025 04:51
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@docker-library-bot docker-library-bot force-pushed the external-pins-mcr.microsoft.com branch from dd08155 to 7a52a67 Compare February 14, 2025 04:51
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@docker-library-bot docker-library-bot force-pushed the external-pins-mcr.microsoft.com branch from 7a52a67 to 01892de Compare February 18, 2025 22:51
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@docker-library-bot docker-library-bot force-pushed the external-pins-mcr.microsoft.com branch from 01892de to 703ccb3 Compare February 26, 2025 04:51
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@docker-library-bot docker-library-bot force-pushed the external-pins-mcr.microsoft.com branch from 703ccb3 to bb790aa Compare February 27, 2025 04:51
@github-actions GitHub Actions
Copy link

Diff for bb790aa: 
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json
index 531fca5..26a68d1 100644
--- a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/bashbrew.json
@@ -2,21 +2,21 @@
 	"arches": {
 		"windows-amd64": [
 			{
-				"digest": "sha256:706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356",
+				"digest": "sha256:fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a",
 				"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
 				"platform": {
 					"architecture": "amd64",
 					"os": "windows",
-					"os.version": "10.0.26100.2894"
+					"os.version": "10.0.26100.3194"
 				},
 				"size": 429
 			}
 		]
 	},
 	"desc": {
-		"digest": "sha256:d584aae93e84d61c8a3280ed3a5d5a6d397c0214a2902acadb8b17b0b00c70e8",
+		"digest": "sha256:d629541ac36f4e051531123eee7226dbfcf55970298953fceef03bc378d31f2a",
 		"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
 		"size": 350
 	},
-	"ref": "mcr.microsoft.com/windows/nanoserver:ltsc2025@sha256:d584aae93e84d61c8a3280ed3a5d5a6d397c0214a2902acadb8b17b0b00c70e8"
+	"ref": "mcr.microsoft.com/windows/nanoserver:ltsc2025@sha256:d629541ac36f4e051531123eee7226dbfcf55970298953fceef03bc378d31f2a"
 }
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a-config.json
similarity index 67%
rename from .external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json
rename to .external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a-config.json
index f40f6f3..7c9ad9a 100644
--- a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356-config.json
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a-config.json
@@ -21,18 +21,18 @@
 		"Volumes": null,
 		"WorkingDir": ""
 	},
-	"created": "2025-01-13T02:49:59.9749213Z",
+	"created": "2025-02-08T22:31:47.5655094Z",
 	"history": [
 		{
-			"created": "2025-01-13T02:49:59.9749213Z",
-			"created_by": "Apply image 10.0.26100.2894"
+			"created": "2025-02-08T22:31:47.5655094Z",
+			"created_by": "Apply image 10.0.26100.3194"
 		}
 	],
 	"os": "windows",
-	"os.version": "10.0.26100.2894",
+	"os.version": "10.0.26100.3194",
 	"rootfs": {
 		"diff_ids": [
-			"sha256:15b8f3150725715e784897c6f3b867f9a4f310eec8c2ac41cd97004bd7a69640"
+			"sha256:17f19cf6311041b36139790c1652f6302dc2c3ec4871791fc61c081bb4a21e57"
 		],
 		"type": "layers"
 	}
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a.json
similarity index 59%
rename from .external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json
rename to .external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a.json
index 9cf40c2..7864177 100644
--- a/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_706a6fa7d39d62f4087963a9dfd20f4579d2f7361594a4f642da60c9b0f54356.json
+++ b/.external-pins/mcr.microsoft.com/windows/nanoserver___ltsc2025/manifest-sha256_fab5bcfc17ba57551db12efcb78dc752c5097e3b6a501389925d7d447c0c819a.json
@@ -1,14 +1,14 @@
 {
 	"config": {
-		"digest": "sha256:9d0196791c1c8c96145b0fa04e3ee4c1a3ca8bf26727dad93edfc56b80129665",
+		"digest": "sha256:63010c5bfbfa3380d7bf1f59a5f77081d4f7483bd492f96f2f3a9d0cf2aba389",
 		"mediaType": "application/vnd.docker.container.image.v1+json",
 		"size": 638
 	},
 	"layers": [
 		{
-			"digest": "sha256:a3c186345058f6f1d0536c64201b932a82e2c620edf75e054435d7ca6a3ed675",
+			"digest": "sha256:0c8aa567ad1941bb61fe9266784f999c77c9eb7cb8d887d32edc8e561ad34ec6",
 			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
-			"size": 193303215
+			"size": 199943328
 		}
 	],
 	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json
index 06e511b..5d07307 100644
--- a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/bashbrew.json
@@ -2,7 +2,7 @@
 	"arches": {
 		"windows-amd64": [
 			{
-				"digest": "sha256:da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28",
+				"digest": "sha256:cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1",
 				"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
 				"platform": {
 					"architecture": "amd64",
@@ -10,16 +10,16 @@
 					"os.features": [
 						"win32k"
 					],
-					"os.version": "10.0.26100.2894"
+					"os.version": "10.0.26100.3194"
 				},
 				"size": 596
 			}
 		]
 	},
 	"desc": {
-		"digest": "sha256:f6153b44882e7ada8fa17123cfca1da3f29ea7fbe062c9e931240dc837aa4256",
+		"digest": "sha256:44b2884c5db9f03d57b7494371706cf95d4345c75399c420e63b5f5609313ee6",
 		"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
 		"size": 375
 	},
-	"ref": "mcr.microsoft.com/windows/servercore:ltsc2025@sha256:f6153b44882e7ada8fa17123cfca1da3f29ea7fbe062c9e931240dc837aa4256"
+	"ref": "mcr.microsoft.com/windows/servercore:ltsc2025@sha256:44b2884c5db9f03d57b7494371706cf95d4345c75399c420e63b5f5609313ee6"
 }
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1-config.json
similarity index 73%
rename from .external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json
rename to .external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1-config.json
index 04b3a64..df528bf 100644
--- a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28-config.json
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1-config.json
@@ -21,23 +21,23 @@
 		"Volumes": null,
 		"WorkingDir": ""
 	},
-	"created": "2025-01-13T03:08:16.9200244Z",
+	"created": "2025-02-08T22:54:28.3301623Z",
 	"history": [
 		{
 			"created": "2024-12-08T22:41:37.6430686Z",
 			"created_by": "Apply image 10.0.26100.2605"
 		},
 		{
-			"created": "2025-01-13T03:08:16.9200244Z",
-			"created_by": "Install update 10.0.26100.2894"
+			"created": "2025-02-08T22:54:28.3301623Z",
+			"created_by": "Install update 10.0.26100.3194"
 		}
 	],
 	"os": "windows",
-	"os.version": "10.0.26100.2894",
+	"os.version": "10.0.26100.3194",
 	"rootfs": {
 		"diff_ids": [
 			"sha256:6f03bf56adda4553bbee2716396f5b39d873cfdbf24bbe2224ad483e2ea38bbd",
-			"sha256:4fb7d3c0cc9f887880105f122d922670a208321e62b898fe8d2541af7423a658"
+			"sha256:e669f4d2a227ba4ca1f8187ac958c97a368a365b329667ba010f5a301eca4bda"
 		],
 		"type": "layers"
 	}
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1.json
similarity index 70%
rename from .external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json
rename to .external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1.json
index af91ff4..89e35e2 100644
--- a/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_da20c9f897d4e5648048577a5c21d81d1237d2f734c0692b987fd000b3245f28.json
+++ b/.external-pins/mcr.microsoft.com/windows/servercore___ltsc2025/manifest-sha256_cd61ef2ef2be1cd20e06686d3b554843e5d713017037e108788ad3417ff981c1.json
@@ -1,6 +1,6 @@
 {
 	"config": {
-		"digest": "sha256:f21109c0924d0f738e16c937ba525079968c51462480aeb7beb6412d93299615",
+		"digest": "sha256:0311960532d12eff01b21bfb876393a0d7b63c892f692f922e9dc4599f2a861a",
 		"mediaType": "application/vnd.docker.container.image.v1+json",
 		"size": 788
 	},
@@ -11,9 +11,9 @@
 			"size": 2155572515
 		},
 		{
-			"digest": "sha256:e16205cfa699ab31943b0afd8cc5da678176f3910e866afe71b1afcf253f67fc",
+			"digest": "sha256:c63ba28597543b393ef0b663bfa0a27371c4ec7b589305f8e38a22dd5fe86d42",
 			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
-			"size": 277091899
+			"size": 584660574
 		}
 	],
 	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",

@tianon
Copy link
Member Author

tianon commented Feb 27, 2025

https://github.com/yosifkit/fuzzy-octo-engine/actions/runs/13571858257 looks like we're good to go? 👀

@yosifkit
Copy link
Member

yosifkit commented Feb 27, 2025 •
edited
Loading

https://github.com/yosifkit/fuzzy-octo-engine/actions/runs/13571858257 looks like we're good to go? 👀

Oh, yeah, I think the windows-2025 runner migration is close enough to fully migrated. There are 0-2 failures out of 60 runs across each of my actions pipelines in the last 6 hours and that's not much worse that what we usually get with different external failures across our builds.

@yosifkit yosifkit merged commit 629529e into docker-library:master Feb 27, 2025
6 checks passed
@yosifkit yosifkit deleted the external-pins-mcr.microsoft.com branch February 27, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosifkit yosifkit yosifkit approved these changes

Assignees
No one assigned
Labels
external/mcr.microsoft.com/windows/nanoserver external/mcr.microsoft.com/windows/servercore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianon @yosifkit @docker-library-bot