Skip to content

PASSWORD_ARGON2I constant undefined in 7.2-alpine #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forevermatt opened this issue Jun 1, 2018 · 5 comments
Closed

PASSWORD_ARGON2I constant undefined in 7.2-alpine #659

forevermatt opened this issue Jun 1, 2018 · 5 comments
Labels

Comments

@forevermatt
Copy link

While testing password_hash() in PHP 7.2, I noticed that the 7.2-alpine Docker image seems to lack the PASSWORD_ARGON2I constant.

Example of error:

$ docker run --rm -it library/php:7.2-alpine ash
/ # php -r "echo PASSWORD_ARGON2I . PHP_EOL;"

Warning: Use of undefined constant PASSWORD_ARGON2I - assumed 'PASSWORD_ARGON2I' (this will throw an Error in a future version of PHP) in Command line code on line 1
PASSWORD_ARGON2I

Example of expected behavior (using the 7.2 image):

$ docker run --rm -it library/php:7.2 bash
root@068d1b669538:/# php -r "echo PASSWORD_ARGON2I . PHP_EOL;"
2

I don't know if it's related to the LibreSSL configuration discussion here, but this seemed worth mentioning since the new password hashing stuff is one of the great benefits of PHP 7.2

@wglambert wglambert added the Issue label Jun 1, 2018
@yosifkit
Copy link
Member

yosifkit commented Jun 4, 2018

From #515 (comment)

Looks like the library is libargon2-0-dev in Debian -- it's in Alpine also (argon2-dev), but only in edge.

Unfortunately this is still true, so perhaps with Alpine 3.8 we can have the argon2 library.

@TBK
Copy link

TBK commented Jun 12, 2018

Create an issue on https://bugs.alpinelinux.org/ and it might get backported.

@tianon
Copy link
Member

tianon commented Jul 16, 2018

I think updating to Alpine 3.8 (now that it's released) is probably our best bet forward here (ala #683).

@TimWolla
Copy link
Contributor

I think updating to Alpine 3.8 (now that it's released) is probably our best bet forward here (ala #683).

Yes, #677 adds support for Argon 2 to the Alpine 3.8 based images: 7e230c9

@tianon
Copy link
Member

tianon commented Aug 21, 2018

Woot, this is fixed (and will be published once docker-library/official-images#4752 merges). 👍

Thanks @TimWolla and @forevermatt!

@tianon tianon closed this as completed Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants