Add PHP 7.3-rc #677

TimWolla · 2018-06-26T18:34:08Z

Did a build with stretch-fpm + a bunch of extensions.

TimWolla · 2018-06-27T21:11:01Z

Tests fail for alpine only. A similar error message has been reported for qemu: https://bugs.alpinelinux.org/issues/5768

I don't know enough about alpine / musl / ld / PHP / libssl to advise on this.

TimWolla · 2018-06-27T21:12:45Z

And there's also this bug report for PHP itself: https://bugs.php.net/bug.php?id=76392

TimWolla · 2018-06-30T14:56:42Z

Probably will be fixed when php/php-src#3349 is merged.

tianon · 2018-07-09T15:39:37Z

Looks like the version of Argon2 in Stretch also isn't new enough for PHP 7.3's requirements. 😞

tianon · 2018-07-09T21:28:41Z

@TimWolla linked to php/php-src@55277a6 in IRC (chased down the commit which added this new version restriction)

TimWolla · 2018-07-10T10:53:05Z

As discussed in IRC: I added apt pinning to buster for libargon2. I opted to pin libargon2 for both 7.2 and 7.3 running on Stretch. If the changes are fine then this PR should “go green” once PHP 7.3 RC 1 lands, because that fixes the alpine issue.

TimWolla · 2018-07-10T10:54:03Z

.travis.yml

+  - VERSION=7.3-rc VARIANT=alpine3.7/cli
+  - VERSION=7.3-rc VARIANT=alpine3.7/fpm
+  - VERSION=7.3-rc VARIANT=alpine3.7/zts
+  - VERSION=7.3-rc VARIANT=alpine3.6/cli


Do we want alpine 3.6 / 3.7 for 7.3 or should we go full 3.8?

Yes, let's do only Alpine 3.8 for php:7.3. The plan is to migrate the others to 3.8 eventually anyway (probably by dropping 3.6).

yosifkit · 2018-07-12T00:31:32Z

It seems the alpine versions are still hitting https://bugs.php.net/bug.php?id=76392.

TimWolla · 2018-07-12T06:15:53Z

Yes, they are. I linked that bug and the GitHub PR fixing it above: #677 (comment) It thus *should* work with the next release. yosifkit <[email protected]> schrieb am Do., 12. Juli 2018, 02:31:

…

It seems the alpine versions are hitting https://bugs.php.net/bug.php?id=76392. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#677 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMxdh-itM8SD7vG7UEtwjST5rwDewl_ks5uFpjqgaJpZM4U4dlF> .

TimWolla · 2018-07-19T11:06:52Z

All the 7.3-rc variants are GREEN now 🙌 PHP 7.2 and lower is still building.

@tianon @yosifkit I believe this PR is ready to be reviewed and merged. Take a look at the two issues I referenced above, they are more or less related to the changed I did.

khs1994 · 2018-07-19T15:36:31Z

Alpine 3.8 include wget redis/docker-library-redis#151

yosifkit · 2018-07-27T21:43:29Z

Given that libargon2-0-dev has some strange transition issues in Debian Buster/Sid (specifically related to libargon2-0-dev, libargon2-1-dev, and libargon2-dev, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902972), I am a bit hesitant to use it since it is so unstable/uncertain.

We might as well just download and compile it ourselves until it is in a stable release on Debian. cc @tianon.

Perhaps we should put the argon2 download/install in a Dockerfile part like the apache and fpm blocks?

TimWolla · 2018-07-27T22:08:34Z

Given that libargon2-0-dev has some strange transition issues in Debian Buster/Sid (specifically related to libargon2-0-dev, libargon2-1-dev, and libargon2-dev, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902972), I am a bit hesitant to use it since it is so unstable/uncertain.

If I understand it correctly then libargon2-0-dev is being renamed to libargon2-dev, because Debian does not want to ship several minor versions (the 0 being superfluous then). libargon2-0dev is a virtual package pulling in libargon2-dev (libargon2-1) in sid. libargon2.1 is API compatible with libargon2.0 as I understand it.

Conclusion: The only thing that may change in the near future is the ABI, which is irrelevant here, because we compile from source.

TimWolla · 2018-07-27T22:12:27Z

We might need to update the apt pinning from libargon2-0* to libargon2*, though.

TimWolla · 2018-07-27T22:34:44Z

Ooookay, I actually just performed a local build against sid, which already has the changes:

In the current form the pinning will break the build once the migration to buster happens:

root@bfcc019cf041:/# apt install libargon2-0-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libargon2-0-dev : Depends: libargon2-0 (= 0~20160821-1+b1) but 0~20171227-0.1 is to be installed
E: Unable to correct problems, you have held broken packages.

My suggestion thus would be: Pin libargon to sid instead of buster. As buster usually is only about 10 days behind sid for most packages the pinning difference should be negligible. When libargon is pinned to sid one has to change libargon2-0-dev to libargon2-dev in the actual apt-get install invocation, since the former refers to stretch (probably a side effect of it being a virtual package in sid).

After making these changes php:7.3-cli builds fine for me:

[timwolla@/s/D/o/p/7/s/cli (php-7.3)]g d                                                                                                                                                                    00:34:07
diff --git i/7.3-rc/stretch/cli/Dockerfile w/7.3-rc/stretch/cli/Dockerfile
index 493a5f2..6d84fb5 100644
--- i/7.3-rc/stretch/cli/Dockerfile
+++ w/7.3-rc/stretch/cli/Dockerfile
@@ -17,20 +17,18 @@ RUN set -eux; \
 
 RUN    set -eux; \
        { \
-               echo 'deb http://deb.debian.org/debian buster main'; \
-               echo 'deb http://deb.debian.org/debian buster-updates main'; \
-               echo 'deb http://security.debian.org buster/updates main'; \
+               echo 'deb http://deb.debian.org/debian sid main'; \
        } >> /etc/apt/sources.list; \
        { \
                echo 'Package: *'; \
-               echo 'Pin: release n=buster'; \
+               echo 'Pin: release n=sid'; \
                echo 'Pin-Priority: 100'; \
-       } > /etc/apt/preferences.d/no-buster; \
+       } > /etc/apt/preferences.d/no-sid; \
        { \
-               echo 'Package: libargon2-0*'; \
-               echo 'Pin: release n=buster'; \
+               echo 'Package: libargon2*'; \
+               echo 'Pin: release n=sid'; \
                echo 'Pin-Priority: 990'; \
-       } > /etc/apt/preferences.d/argon-buster
+       } > /etc/apt/preferences.d/argon-sid
 
 # dependencies required for running "phpize"
 # (see persistent deps below)
@@ -122,7 +120,7 @@ RUN set -eux; \
        savedAptMark="$(apt-mark showmanual)"; \
        apt-get update; \
        apt-get install -y --no-install-recommends \
-               libargon2-0-dev \
+               libargon2-dev \
                libcurl4-openssl-dev \
                libedit-dev \
                libsodium-dev \

see: #677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

TimWolla · 2018-08-05T13:17:17Z

My suggestion thus would be: Pin libargon to sid instead of buster.

I did this, as the migration from sid to buster already happened and the build broke.

This PR is updated to the current PHP 7.3 Beta 1.

tianon · 2018-08-10T20:52:17Z

I'm definitely not thrilled about pulling from sid, and even pulling from buster causes headaches for us a lot of the time (in other images where we have to do similar things). I'm starting to wonder if it makes sense for us to just compile Argon2 from source all the time and avoid all this headache.

Also, as @yosifkit mentioned above, it's kind of odd that the templating bits for the Argon2 section aren't consistent with the other templating this repo is using.

Would you rather we take over from here and just get this across the finish line?

TimWolla · 2018-08-10T21:13:23Z

Tianon Gravi <[email protected]> schrieb am Fr., 10. Aug. 2018, 22:52:

Would you rather we take over from here and just get this across the finish line? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#677 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMxdu-hrMPs-2ABsYD3wul2kRrek_Jcks5uPfKJgaJpZM4U4dlF> .

Do whatever you want with my PR, please. You are free to push into the branch in my repository. You are free to close it as well. Just ship 7.3 already 😇

…

… match the templating

TimWolla · 2018-08-14T21:50:01Z

🙌

renatomefi · 2018-08-15T17:24:48Z

That's awesome! What's the final tag? I'd guess php:7.3-rc-cli-alpine3.8, is that so?
When can it be pushed? the last push in the repo was 25 days ago!

Thanks a lot for this great work!

tianon · 2018-08-15T17:25:47Z

https://github.com/docker-library/php#see-a-change-merged-here-that-doesnt-show-up-on-docker-hub-yet 😉

(There'll be a PR later today.)

- `docker`: 18.06.1-ce-rc2, `alpine:3.8` (docker-library/docker#124) - `mariadb`: 10.3.9 - `mongo`: 4.1.2 - `php`: 7.3-rc (docker-library/php#677), 7.2/alpine3.8 (docker-library/php#688)

This test verifies that Argon2 actually works for PHP images where it should. This is to ensure that the Argon2 from Buster does not magically change to become incompatible. see: docker-library/php#677 (comment)

- `drupal`: 8.6.0-rc1 - `ghost`: ghost-cli 1.9.1 - `memcached`: Alpine 3.8 (docker-library/memcached#40) - `mongo`: 3.6.7, `dbPath` fixes (docker-library/mongo#294) - `openjdk`: 11-ea+27 (Debian) - `percona`: 5.5.61, 5.6.41 - `php`: 7.1.21, Alpine 3.8 (docker-library/php#702, docker-library/php#688), 7.3.0beta2 (docker-library/php#677), 7.2.9 - `postgres`: fix `HOME` (docker-library/postgres#481) - `python`: `apk add --no-cache` to combat new `apk` behavior (docker-library/python#330) - `ruby`: bundler 1.16.4 - `tomcat`: 8.5.33, 9.0.11

see: docker-library/php#677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

TimWolla commented Jul 10, 2018

View reviewed changes

This was referenced Jul 19, 2018

Add alpine3.8 for php 7.2 #688

Merged

PASSWORD_ARGON2I constant undefined in 7.2-alpine #659

Closed

TimWolla added 8 commits August 1, 2018 14:10

Add PHP 7.3-rc

a4b4d71

Update to PHP 7.3.0 Alpha 3

a8b0940

Install libargon2 from buster

1fdbc53

Ship PHP 7.3 with Alpine 3.8

5d82c0b

Enable argon2 for alpine 3.8+

edf4f2f

Update to PHP 7.3.0 Alpha 4

2b87be8

Update to PHP 7.3.0 Beta 1

a3f5e09

Install libargon2 from sid

e1a4aff

see: #677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

Swap from "sid" to "buster" and slightly adjust the implementation to…

c53a180

… match the templating

tianon requested a review from yosifkit August 13, 2018 22:13

yosifkit approved these changes Aug 14, 2018

View reviewed changes

yosifkit merged commit 43b47cc into docker-library:master Aug 14, 2018

TimWolla deleted the php-7.3 branch August 14, 2018 21:26

tianon mentioned this pull request Aug 15, 2018

Update docker-library images docker-library/official-images#4733

Merged

TimWolla mentioned this pull request Aug 15, 2018

Add test to verify Argon2 works in PHP docker-library/official-images#4734

Merged

tianon mentioned this pull request Aug 21, 2018

Update docker-library images docker-library/official-images#4752

Merged

ReactDevs007 added a commit to ReactDevs007/dockerlib that referenced this pull request Feb 3, 2021

Install libargon2 from sid

7ed54a9

see: docker-library/php#677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

VenusPR pushed a commit to VenusPR/PHP_Project that referenced this pull request Mar 12, 2023

Install libargon2 from sid

8fbab2c

see: docker-library/php#677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

principlesoftware-dev added a commit to principlesoftware-dev/PHP-branch that referenced this pull request Sep 2, 2024

Install libargon2 from sid

74a06f2

see: docker-library/php#677 (comment) see: https://travis-ci.org/docker-library/php/jobs/411259094

Add PHP 7.3-rc #677

Add PHP 7.3-rc #677

Uh oh!

Conversation

TimWolla commented Jun 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TimWolla commented Jun 27, 2018

Uh oh!

TimWolla commented Jun 27, 2018

Uh oh!

TimWolla commented Jun 30, 2018

Uh oh!

tianon commented Jul 9, 2018

Uh oh!

tianon commented Jul 9, 2018

Uh oh!

TimWolla commented Jul 10, 2018

Uh oh!

TimWolla Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

yosifkit Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

TimWolla Jul 10, 2018

Choose a reason for hiding this comment

Uh oh!

yosifkit commented Jul 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TimWolla commented Jul 12, 2018 via email

Uh oh!

TimWolla commented Jul 19, 2018

Uh oh!

khs1994 commented Jul 19, 2018

Uh oh!

yosifkit commented Jul 27, 2018

Uh oh!

TimWolla commented Jul 27, 2018

Uh oh!

TimWolla commented Jul 27, 2018

Uh oh!

TimWolla commented Jul 27, 2018

Uh oh!

TimWolla commented Aug 5, 2018

Uh oh!

tianon commented Aug 10, 2018

Uh oh!

TimWolla commented Aug 10, 2018 via email

Uh oh!

TimWolla commented Aug 14, 2018

Uh oh!

renatomefi commented Aug 15, 2018

Uh oh!

tianon commented Aug 15, 2018

Uh oh!

Uh oh!

TimWolla commented Jun 26, 2018 •

edited

Loading

yosifkit commented Jul 12, 2018 •

edited

Loading