Add alpine3.8 for php 7.2 #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for reference, see this comment in #677: #677 (comment) |
|
@TimWolla thank you, i added this as well |
|
Will this have support for Argon 2? Edit: Nevermind I just saw it in the change file list! Yay |
|
Are there something blocking this merge? Would like to not change my current multi-stage Dockerfile based on Alpine to Debian only for Argon2 :) |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 15, 2018
- `docker`: 18.06.1-ce-rc2, `alpine:3.8` (docker-library/docker#124) - `mariadb`: 10.3.9 - `mongo`: 4.1.2 - `php`: 7.3-rc (docker-library/php#677), 7.2/alpine3.8 (docker-library/php#688)
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 21, 2018
- `drupal`: 8.6.0-rc1 - `ghost`: ghost-cli 1.9.1 - `memcached`: Alpine 3.8 (docker-library/memcached#40) - `mongo`: 3.6.7, `dbPath` fixes (docker-library/mongo#294) - `openjdk`: 11-ea+27 (Debian) - `percona`: 5.5.61, 5.6.41 - `php`: 7.1.21, Alpine 3.8 (docker-library/php#702, docker-library/php#688), 7.3.0beta2 (docker-library/php#677), 7.2.9 - `postgres`: fix `HOME` (docker-library/postgres#481) - `python`: `apk add --no-cache` to combat new `apk` behavior (docker-library/python#330) - `ruby`: bundler 1.16.4 - `tomcat`: 8.5.33, 9.0.11
|
Be careful! PHP 7.2's Reference: https://igotaprinter.com/blog/argon2i-php-password-hash-not-compatible-libsodium.html (site has expired SSL certificate 😆) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, i dont know if this is enough, i compared 3.6 and 3.7 and found that only the base image was needed to change, so i hope this will do for 3.8 as well (#683).