Skip to content

Add alpine3.8 for php 7.2 #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Add alpine3.8 for php 7.2 #688

merged 1 commit into from
Aug 15, 2018

Conversation

nick-zh
Copy link
Contributor

@nick-zh nick-zh commented Jul 17, 2018

Hey guys, i dont know if this is enough, i compared 3.6 and 3.7 and found that only the base image was needed to change, so i hope this will do for 3.8 as well (#683).

@nick-zh
Copy link
Contributor Author

nick-zh commented Jul 18, 2018

@tianon @yosifkit please let me know if there is something missing guys

@TimWolla
Copy link
Contributor

for reference, see this comment in #677: #677 (comment)

@nick-zh
Copy link
Contributor Author

nick-zh commented Jul 19, 2018

@TimWolla thank you, i added this as well

@TimWolla
Copy link
Contributor

@nick-zh My comment was primarily intended for the maintainers (tianon / yosifkit): Ideally #677 should be merged first, because you forgot to update update.sh to add Alpine 3.8 support:

php/update.sh

Line 128 in b9d625c

for suite in stretch jessie alpine{3.7,3.6}; do

@lbadger
Copy link

lbadger commented Aug 4, 2018

Will this have support for Argon 2?

Edit: Nevermind I just saw it in the change file list! Yay

@jesugmz
Copy link

jesugmz commented Aug 8, 2018

Are there something blocking this merge? Would like to not change my current multi-stage Dockerfile based on Alpine to Debian only for Argon2 :)

@nick-zh
Copy link
Contributor Author

nick-zh commented Aug 9, 2018

@jesugmz i don't think so, i added the necessary changes from @TimWolla's PR #677 (hope i got them all) and right now we are just waiting for @tianon and @yosifkit to approve and merge those changes afaik

@tianon tianon merged commit c7ee854 into docker-library:master Aug 15, 2018
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 15, 2018
- `docker`: 18.06.1-ce-rc2, `alpine:3.8` (docker-library/docker#124)
- `mariadb`: 10.3.9
- `mongo`: 4.1.2
- `php`: 7.3-rc (docker-library/php#677), 7.2/alpine3.8 (docker-library/php#688)
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 21, 2018
- `drupal`: 8.6.0-rc1
- `ghost`: ghost-cli 1.9.1
- `memcached`: Alpine 3.8 (docker-library/memcached#40)
- `mongo`: 3.6.7, `dbPath` fixes (docker-library/mongo#294)
- `openjdk`: 11-ea+27 (Debian)
- `percona`: 5.5.61, 5.6.41
- `php`: 7.1.21, Alpine 3.8 (docker-library/php#702, docker-library/php#688), 7.3.0beta2 (docker-library/php#677), 7.2.9
- `postgres`: fix `HOME` (docker-library/postgres#481)
- `python`: `apk add --no-cache` to combat new `apk` behavior (docker-library/python#330)
- `ruby`: bundler 1.16.4
- `tomcat`: 8.5.33, 9.0.11
@teohhanhui
Copy link

Be careful!

PHP 7.2's password_verify does NOT support argon2id. If you have previously been using the sodium extension's sodium_crypto_pwhash to encode the password, the default algorithm has been argon2id for some time now. Just a heads-up!

Reference: https://igotaprinter.com/blog/argon2i-php-password-hash-not-compatible-libsodium.html (site has expired SSL certificate 😆)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants