Use bundled pcre and disable pcre-jit on unsupported platforms #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upported platforms like s390x
tianon
approved these changes
Nov 29, 2017
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Nov 30, 2017
- `ghost` bump to `1.18.2` - `mongo` bump to `3.6.0-rc7` - `php` `7.2` GA and pcre-jit fixes docker-library/php#526 - `redis` bump to `4.0.4` - `tomcat` bumps to `8.5.24` and `9.0.2` - `wordpress` bump to `4.9.1`
mcnilz
added a commit
to webvariants/sally-docker
that referenced
this pull request
Dec 1, 2017
This reverts commit af26297. Fixed by docker-library/php#526
|
Oh snap, this root@b67fdb51912b:/usr/src/php# ./configure --help | grep pcre
--with-pcre-regex=DIR Include Perl Compatible Regular Expressions support.
--with-pcre-dir FILTER: pcre install prefix
--with-pcre-dir ZIP: pcre install prefix |
|
Welp, it was added in php/php-src@54d8053 (which explains why it's 7.0+). Guess at some point we might need some kind of workaround for compiling 5.6 on s390x (although I haven't seen any complaints about it yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495. Thanks to @GordonHarley's comment.
I've successfully built this on s390x. 🎉