-
Notifications
You must be signed in to change notification settings - Fork 2k
Added compile option --with-mysqli in versions with Apache #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would it be bad to just drop the Other than my question, LGTM. |
I thought about that, I think leaving it in is probably the right call since people might want to migrate old codebases into docker. I don't do much php development though (only noticed this when migrating some hackerspace projects into docker), so maybe someone with more PHP experience can chime in? |
I'm +1 on keeping both, especially since the older stuff is still in pretty |
Then what about PDO? |
That's a good point, I didn't add PDO as I wasn't that familiar with it. I'm usually averse to adding a million compile flags, but it probably makes sense as this is supposed to be a base language pack. |
I'll add it to this PR if you two think it's the right way to go. |
Sounds good to me. @tianon? |
Added compile option --with-mysqli in versions with Apache
Add polyscripting dependencies
Addresses #6