Sets PHP error level for getting extension dir #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an uncaught exception is thrown during parsing of the php.ini file, `$extDir` will contain a combination of the exception and the path. This script shouldn't care about error messages though as long as it gets the path. This updates the script so that php won't emit any error messages.
|
Good catch! I think instead of ignoring them though, we should have them go to (I'll have a commit that does that shortly which also updates the generated versions so this can run through our full test suite via Travis too. 👍) |
yosifkit
approved these changes
Jun 7, 2019
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 8, 2019
Changes: - docker-library/php@10c1eee: Merge pull request docker-library/php#837 from magikid/master - docker-library/php@a7e2de0: Send PHP errors/warnings to stderr in our scripts - docker-library/php@54c2790: Sets PHP error level for getting extension dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an uncaught exception is thrown during parsing of the php.ini file,
$extDirwill contain a combination of the exception and the path. This script shouldn't care about error messages though as long as it gets the path. This updates the script so that php won't emit any error messages.